fix scientific notation in scale notation, fix #36859 #36860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
approved these changes
Jun 1, 2020
SebastienPeillet
force-pushed
the
fix_scale_display_with_qlocale
branch
4 times, most recently
from
b0146d4
to
c5e02f5
Compare
nyalldawson
added
backport release-3_10
Bug
nyalldawson
reviewed
Jun 2, 2020
SebastienPeillet
force-pushed
the
fix_scale_display_with_qlocale
branch
5 times, most recently
from
3431cf8
to
5a9f794
Compare
|
This is failing on azure (it's not related to the current failure of the 32 bit builds either) |
…ation (due to separator character)
SebastienPeillet
force-pushed
the
fix_scale_display_with_qlocale
branch
from
5a9f794
to
6b799d8
Compare
Yes, results are different according to Qt version. I fixed it ! |
SebastienPeillet
removed
the
Squash!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bugs with project predefined scales. Using this feature, smal scale are displayed with scientific notation (see #36859). It break the use of the QgsScaleComboBox, and alter the use of the Predefined scales configuration in Project properties.
Internationalization was not fully used which causes troubles to convert int to string and vice versa.