warn if there is no style associated with a rule (fix #23048) #36954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbruy
added
GUI/UX
nyalldawson
reviewed
Jun 4, 2020
nyalldawson
reviewed
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If layer styled with rule-based renderer and some rules have no symbol associated with them user still have "Edit Symbol" entry in the legend entry context menu. Clicking on "Edit Symbol" in this case does nothing (which is correct as there is no symbol) and can be confusing.
Proposed PR adds a popup message explaining that corresponding rule does not have any symbol associated with it. Fixes #23048.
Probably can be backported to 3.10.