Use a filter proxy model for the dependencies layer tree #37000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Jun 6, 2020
| This will refresh the model | ||
| %End | ||
|
|
||
| void setMapLayerTypeFilter( const QList<QgsMapLayerType> &types = QList<QgsMapLayerType>() ); |
There was a problem hiding this comment.
Wouldn't it be better to reuse the filters from the map layer model proxy instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layer tree for dependencies (in vector layer properties) was showing symbols and also the main layer.
This fixes this by using a layer tree filter proxy model (similarly to the snapping and data sources).
I have create a re-usable base class
QgsLayerTreeFilterProxyModelwhich makes this easy.Next step (after release I guess), would be to use the same base class in other places (snapping, data sources, DXF export, …)