Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Fix image size ignored in image widget #37168

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jun 12, 2020

Fixes #33682 (maybe)

Cherry-pick from master commit 72c0ae7

Fixes qgis#33682  (maybe)

Cherry-pick from master commit 72c0ae7
@elpaso elpaso added Backport Is a backport of another pull request Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jun 12, 2020
@github-actions github-actions bot added this to the 3.10.7 milestone Jun 12, 2020
@m-kuhn
Copy link
Member

m-kuhn commented Jun 12, 2020

How can the "maybe" be interpreted?

@elpaso
Copy link
Contributor Author

elpaso commented Jun 12, 2020

See the explanations in the original PR #37093

@elpaso elpaso changed the title Fix image size ignored in image widget [backport] Fix image size ignored in image widget Jun 12, 2020
@m-kuhn
Copy link
Member

m-kuhn commented Jun 12, 2020

Note to self:

I don't know if this really solves the issue because I cannot reproduce it exactly but I'm sure that it solves the bug that the image sizes were completely ignored.

To be sure I interpret that correctly, this PR is scheduled to be merged after confirmation of the master fix?

@elpaso
Copy link
Contributor Author

elpaso commented Jun 12, 2020

@m-kuhn no: this is a bug fix I'm 100% sure of it. The only thing I'm not sure about is if this solves completely or partially the bug #33682.

It must be merged.

@m-kuhn
Copy link
Member

m-kuhn commented Jun 12, 2020

So "tentative fix", let's close, hope for the best; and reopen in case someone still bumps into it?

@elpaso
Copy link
Contributor Author

elpaso commented Jun 12, 2020

So "tentative fix", let's close, hope for the best; and reopen in case someone still bumps into it?

Yeah, that's the best we can do, I'm pretty confident this fixes the whole issue but I haven't been to reproduce the "growing" effect described in the bug.

Anyway, the widget was completely ignoring the image size parameters, that is the part of the bug that I'm fixing, whether that was the root cause of the "growing effect" or not, I cannot tell.

@m-kuhn
Copy link
Member

m-kuhn commented Jun 12, 2020

Sounds good, looks safe.

@elpaso elpaso merged commit b586a6f into qgis:release-3_10 Jun 12, 2020
@elpaso elpaso deleted the backport-37093 branch June 12, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Is a backport of another pull request Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants