perform rounding either if field type is numeric or if value was casted to the number #37234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QGIS Processing testing framework allows to customize layer comparison. Among options are casting field values to some data type and setting values precision before comparison. But precision can be applied it only if expected field has numeric data type, so if fields have string data type (for example, if test result and expected result saved as CSV) and were casted to int or float setting precision for them won't take any effect.
This was found when investigating test failures in #37039.
Proposed PR allows to apply precision restriction also for fields which were casted to numeric data type. Another option will be to update failing tests and use more robust output format for problematic tests.