[expression] strpos() and regexp_match() improvements #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
strpos_regexp_match_upgrade
branch
from
7e2106c
to
6627183
Compare
|
Logic sounds good to me... could do with a unit test for the new strpos behaviour, ie searching for '.' |
nirvn
force-pushed
the
strpos_regexp_match_upgrade
branch
from
6627183
to
ff777b2
Compare
|
@nyalldawson , test added; feel free to cancel the previously pending travis build check. |
|
Sorry - one last thing. Can you change the commit message to a [FEATURE] so that the documentation team gets pinged and also so that we pick this change up and include it in the release notes. |
- strpos() now relies on a simple string within a string search - regexp_match() now returns pos of a matching regular expression
nirvn
force-pushed
the
strpos_regexp_match_upgrade
branch
from
ff777b2
to
6b2b4c5
Compare
|
@nyalldawson done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what was discussed in the dev mailing list yesterday (see https://lists.osgeo.org/pipermail/qgis-developer/2016-November/045703.html), namely:
This change means that users using expressions such as
if(regexp_match('blah','blah') = true, ..., ...)won't work as expected anymore, and would have to be re-written toif(regexp_match('blah','blah'), ..., ...).IMHO, since we're allowing ourselves to break stuff prior to release of version 3.0, this expression-breaking improvement is warranted 馃槃