Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing] use algorithm description in modeler dependencies dialog #3741

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Nov 10, 2016

This PR improves the modeler algorithm dependencies UI by using the algorithm's description (attached to the modeler algorithm item) instead of its default name. The reasoning behind this is to avoid duplicates when a given algorithm (for e.g. PostGIS execute SQL) is used more than once in a model.

A picture if worth a thousand words:
untitled
left: current sub-optimal UI, right: proposed improvement

I discovered this while building a complex model. Using the algorithm's default name had me check and uncheck every single duplicate name to try and find the right algorithm in the chain.

@NathanW2
Copy link
Member

Nice work

On Thu, 10 Nov 2016 1:25 pm Mathieu Pellerin notifications@github.com
wrote:

This PR improves the modeler algorithm dependencies UI by using the
algorithm's description (attached to the modeler algorithm item) instead of
its default name. The reasoning behind this is to avoid duplicates when a
given algorithm (for e.g. PostGIS execute SQL) is used more than once in a
model.

A picture if worth a thousand words:
[image: untitled]
https://cloud.githubusercontent.com/assets/1728657/20163514/bb48f272-a72f-11e6-99e7-aba9e1db08a3.png
left: current sub-optimal UI, right: proposed improvement

I discovered this while building a complex model. Using the algorithm's
default name had me check and uncheck every single duplicate name to try

and find the right algorithm in the chain.

You can view, comment on, or merge this pull request online at:

#3741
Commit Summary

  • [processing] use algorithm description in modeler dependencies dialog

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3741, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXS3KGjOQvZlttMr7dnc8-Ttwk2Rd0uks5q8o6PgaJpZM4KuPfb
.

@alexbruy alexbruy merged commit be6672d into qgis:master Nov 10, 2016
@nirvn nirvn deleted the processing_dependencies_improvement branch February 26, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants