Remove unecessary update in the qgsmasksourceselectionwidget constructor #37431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor. Update is done automatically when the mask widget is opened. Should fix qgis#34942.
troopa81
approved these changes
Jun 29, 2020
…ange. Should fix issue qgis#37473.
|
Just added a commit fixing issue #37473 which is linked to the same PR. |
3nids
reviewed
Jul 7, 2020
src/gui/qgsmaskingwidget.cpp
Outdated
|
|
||
| bool QgsMaskingWidget::hasBeenPopulated() | ||
| { | ||
| return mMustPopulate == false; |
There was a problem hiding this comment.
Suggested change
| return mMustPopulate == false; | |
| return !mMustPopulate; |
is a bit more intuitive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unecessary update in the qgsmasksourceselectionwidget constructor. Update is done automatically when the mask widget is opened. Should fix #34942.
It seems the latest changes introduced by PR 36366 removed the check box "Edit mask settings" and changed the behavior to an automatic update of the masking symbol when the "mask" widget is opened within the property view.
But the "update" function was still called when QgsMaskSourceSelectionWidget is constructed at the opening of the layer property view.
This update call is causing the delay and is unnecessary because the update is now done automatically when the mask view is opened.