Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes OGC API Features certification #37622

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

pblottiere
Copy link
Member

@pblottiere pblottiere commented Jul 6, 2020

Description

This PR is a follow-up to #37429 because OGC API Features certification tests are failing since the merge (cf http://test.qgis.org/ogc_cite/ogcapif/2020_07_06_05_00/report.html):

  • ERROR: Value 'bool' does not match required pattern 'boolean|object|array|number|integer|string'
  • ERROR: Path param 'sortby' must have 'required' property set true
  • ERROR: Path param 'sortdesc' must have 'required' property set true

The first issue is fixed but I still have to take a look to others (according to https://apisecurity.io/encyclopedia/content/oasv3/oasconformance/structure/v3-validation-parameter-path-required.htm, a path parameter has to have its property 'required' set to 'true').

@github-actions github-actions bot added this to the 3.16.0 milestone Jul 6, 2020
@pblottiere pblottiere added Server Related to QGIS server Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jul 6, 2020
@elpaso
Copy link
Contributor

elpaso commented Jul 6, 2020

@pblottiere
Copy link
Member Author

@elpaso Thanks for the tip 👍

@elpaso
Copy link
Contributor

elpaso commented Jul 6, 2020

@elpaso Thanks for the tip +1

thank you for cleaning my mess :)

@pblottiere pblottiere force-pushed the fix_ogcapif_json branch 3 times, most recently from e2a81f2 to cf85ab6 Compare July 7, 2020 08:33
@pblottiere
Copy link
Member Author

Azure build is failing but it's not related to this PR.

@pblottiere pblottiere merged commit 7ba050c into qgis:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants