Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid texture jump when panning maps #37734

Merged
merged 4 commits into from
Jul 11, 2020

Conversation

nyalldawson
Copy link
Collaborator

We don't need the whole expense of the "Avoid artifacts when rendering as map tiles"
option, because that disables to default clipping of geometry parts which fall
outside the visible canvas extent and accordingly results in a lot of wasted rendering
calculations. Instead, we can just always use the upper left corner of the original
feature geometry before the optimisations like clipping to visible regions are applied,
and use this as the texture origin.

This means we can safely make this handling always applied and not an opt-in setting

@nyalldawson nyalldawson added the Optimization I feel the need... the need for speed! label Jul 10, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Jul 10, 2020
@andreasneumann
Copy link
Member

Thanks, Nyall!

We don't need the whole expense of the "Avoid artifacts when rendering as map tiles"
option, because that disables to default clipping of geometry parts which fall
outside the visible canvas extent and accordingly results in a lot of wasted rendering
calculations. Instead, we can just always use the upper left corner of the original
feature geometry before the optimisations like clipping to visible regions are applied,
and use this as the texture origin.

This means we can safely make this handling always applied and not an opt-in setting
@nyalldawson nyalldawson merged commit 053d504 into qgis:master Jul 11, 2020
@nyalldawson nyalldawson deleted the no_texture_jump branch July 11, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization I feel the need... the need for speed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants