Manage 3D symbols through style manager #37952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nyalldawson , fantastic work! What about displaying some basic information - such as colors - with the preview icon. We could still use the 3D symbol, but tweak it to reflect part of the saved symbol. E.g.: |
|
@nirvn it's an option I guess - still not a trivial inclusion, so I'd rather explore taking a snapshot of the real symbol first |
nyalldawson
force-pushed
the
3dsym
branch
2 times, most recently
from
3efeade
to
207ebe8
Compare
zacharlie
added
the
Changelog
nyalldawson
force-pushed
the
3dsym
branch
2 times, most recently
from
822defb
to
3373b56
Compare
|
Nice! |
…try is populated Otherwise it's impossible to load these symbols
Because implementing proper thumbnails is a considerable task in itself...
(still not implement -- but a necessary prerequisite to proper icons)
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for managing 3d symbols through the QGIS style manager, including support for importing and exporting libraries of 3d symbols, and completes the recent work in fully abstracting out 3d symbols and their widget handlers.
One notable omission is that there's no thumbnails generated for 3d symbols in the library, and everything gets a generic icon for now. Generating thumbnails is no trivial matter, so it's deffered for now...
Fixes #31479