Wms 1 3 compliance #3812
Merged
Wms 1 3 compliance #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin the WIDTH/HEIGHT parameters
…owed to be empty (also if a layer has only one point)
…ifferent to WIDTH/HEIGHT of requested image
…uests in the capabilities document is a URL prefix
|
👍 |
|
Do you want to backport to 2.14 version ? |
sbrunner
reviewed
Nov 30, 2016
| @@ -77,14 +80,21 @@ void QgsConfigParserUtils::appendCrsElementToLayer( QDomElement& layerElement, c | |||
| layerElement.insertAfter( crsElement, precedingElement ); | |||
| } | |||
|
|
|||
| void QgsConfigParserUtils::appendLayerBoundingBoxes( QDomElement& layerElem, QDomDocument& doc, const QgsRectangle& layerExtent, | |||
| void QgsConfigParserUtils::appendLayerBoundingBoxes( QDomElement& layerElem, QDomDocument& doc, const QgsRectangle& lExtent, | |||
There was a problem hiding this comment.
Maybe I need glasses, could you be more specific what is wrong?
There was a problem hiding this comment.
I miss the line QgsRectangle layerExtent = lExtent; than I suspect an unwanted change :-)
There was a problem hiding this comment.
Ah, I see. Thanks anyway.
|
@rldhont: Yes, a backport to 2.14 makes sense. |
…t for WMS 1.3.0 compliance
…mage width/height
sbrunner
approved these changes
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OGC test suite for WMS 1.3.0 has been run against QGIS server. This PR fixes the issues where the server does not exactly behave as in the specification. With these changes, QGIS server is an OGC compliant WMS 1.3. server.