[symbology] migrate graduated renderer color ramp widget #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
colorrampbutton_migration
branch
from
ef1a39c
to
6bc9efd
Compare
|
@nyalldawson , this PR is green, the red comes from (newly-added / unwanted ?) AppVeyor's unrelated failure. |
nirvn
force-pushed
the
colorrampbutton_migration
branch
from
6bc9efd
to
4645dce
Compare
|
Quick scan looks good to me. |
|
@NathanW2 , thanks. I'll take that as my second green light to merge a PR today 😄 |
|
@nirvn - looks good to me to, but don't forget the api break docs |
|
@nyalldawson , good point. I'm planning to do that when I get rid of the QgsColorRampComboBox class after migration is complete. |
bstroebl
pushed a commit
to bstroebl/QGIS
that referenced
this pull request
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the graduated renderer from the deprecated color ramp combo box to the new color ramp button. I've also taken the opportunity to clean up the layout a bit (i.e. look at the now-aligned "color ramp" label, etc.).
The end result in one screenshot:
Even with the addition of code to deal with the layout improvements, the PR results in fewer lines of code, thanks to the invert logic moved away from UI / renderer into the color ramp itself.
@nyalldawson , as always, your keen eye is most welcome.