Server external wms several layers #38161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erwise the WMS client won't work
elpaso
reviewed
Aug 7, 2020
| QString paramName = paramIt.key().toLower(); | ||
| if ( paramName == QLatin1String( "layers" ) || paramName == QLatin1String( "styles" ) ) | ||
| { | ||
| QStringList values = paramIt.value().split( "," ); |
There was a problem hiding this comment.
Suggested change
| QStringList values = paramIt.value().split( "," ); | |
| QStringList values = paramIt.value().split( ',' ); |
m-kuhn
reviewed
Aug 10, 2020
| { | ||
| QStringList values = paramIt.value().split( "," ); | ||
| QStringList::const_iterator valuesIt = values.constBegin(); | ||
| for ( ; valuesIt != values.constEnd(); ++valuesIt ) |
There was a problem hiding this comment.
const QStringList values = paramIt.value().split( ',' );
for ( const QString &value : values )
wmsUri.setParam( paramName, value );should be much easier to read
m-kuhn
reviewed
Aug 12, 2020
| { | ||
| wmsUri.setParam( paramName, *valuesIt ); | ||
| } | ||
| QStringList values = paramIt.value().split( ',' ); |
There was a problem hiding this comment.
Suggested change
| QStringList values = paramIt.value().split( ',' ); | |
| const QStringList values = paramIt.value().split( ',' ); |
m-kuhn
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An external WMS layer can sometimes request several WMS layers and styles. Up to know, the server passed this as parameter to the WMS client uri. However it seems that it only works if the layers and styles are set one-by-one with wmsUri.setParam. It needs several layers-Parameter with one layer instead one with all the layers (e.g. layers=A&layers=B instead of layers=A,B).