Keep external layers ordering #38548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mhugent, I added/updated unit tests to be more robust, but let me know if you have more ideas. |
pblottiere
added
Bug
|
Thank you, works perfectly now. |
|
Hi @mhugent,
Good, happy to hear that :).
I'll take a look of course, but it's not trivial changes so it could be risky. QGIS 3.16 is the next LTR and is released soon, do you absolutely need this fix for the 3.10 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The external layers management is now delegated to the
QgsWmsRenderContextclass in order to keep a correct order.Unit tests have been updated to be more representative of real use cases (several layers and not only 1 external layer).
Fixes #35873.