-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a checkable combobox for fields configuration flags #38730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds properties tab
3nids
force-pushed
the
conf-flag-check-cb
branch
from
September 14, 2020 11:25
677bb33
to
b923c4a
Compare
nyalldawson
reviewed
Sep 14, 2020
@@ -1968,24 +1968,32 @@ Convenience function that returns the attribute alias if defined or the field na | |||
Returns a map of field name to attribute alias | |||
%End | |||
|
|||
QSet<QString> excludeAttributesWms() const; | |||
QSet<QString> excludeAttributesWms() /Deprecated/ const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!!
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
3nids
force-pushed
the
conf-flag-check-cb
branch
from
September 15, 2020 06:48
e907023
to
21bddfa
Compare
3nids
force-pushed
the
conf-flag-check-cb
branch
2 times, most recently
from
September 15, 2020 08:03
f535f1c
to
e1ab382
Compare
@nyalldawson thanks for the review |
3nids
force-pushed
the
conf-flag-check-cb
branch
2 times, most recently
from
September 15, 2020 08:59
c739f95
to
9bed90b
Compare
3nids
force-pushed
the
conf-flag-check-cb
branch
from
September 15, 2020 10:23
9bed90b
to
7265d9d
Compare
3nids
force-pushed
the
conf-flag-check-cb
branch
from
September 15, 2020 15:34
7c06e89
to
c738609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also migrates the WMS/WFS exclusion to configuration flags