UI: better information message when toggling off edition mode on a transaction group #38780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e edition is turned off hasn't been modified (fixes qgis#38697) We cannot use QgsDataSourceUri::connectionInfo() as it returns an empty string for OGR datasources. So use QgsTransaction::connectionString() as in other places.
…ansaction group Previously, we always displayed the name of the layer we toggled off, even if it was not modified, which could be confusing. Now we will display up to two layer names that have been modified.
nyalldawson
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(On top of PR #38779. Probably not appropriate for backport as it impacts translated strings)
Previously, we always displayed the name of the layer we toggled off, even if
it was not modified, which could be confusing.
Now we will display up to two layer names that have been modified.