Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't html-escape log message in processing panel #38814

Closed
wants to merge 1 commit into from
Closed

Don't html-escape log message in processing panel #38814

wants to merge 1 commit into from

Conversation

pblottiere
Copy link
Member

Description

aa

Fixes #37934.

@pblottiere pblottiere added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 16, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 16, 2020
@pblottiere pblottiere added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Sep 16, 2020
@nyalldawson
Copy link
Collaborator

nyalldawson commented Sep 16, 2020 •
edited
Loading

This fix is not quite correct -- because with it pushing a string like <b>2</b> incorrectly treats the string as HTML. That might seem correct for the log window, but we actually don't support HTML tags in the feedback methods as not all QgsProcessingFeedback subclasses support formatted output (e.g. when running using qgis_process).

#38822 is an alternative approach which fixes both strings

@pblottiere
Copy link
Member Author

OK thanks for the explanation @nyalldawson 👍

@pblottiere pblottiere closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Greater-than and ampersand sign displayed as &gt; and &amp; in Log Message of Processing
2 participants
@pblottiere @nyalldawson