Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if a point is 3D before returning its z value #38831

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Check if a point is 3D before returning its z value #38831

merged 4 commits into from
Sep 30, 2020

Conversation

pblottiere
Copy link
Member

Description

Fixes #37772.

A unit test is in progress.

@pblottiere pblottiere added Expressions Related to the QGIS expression engine or specific expression functions Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Sep 17, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 17, 2020
@nyalldawson nyalldawson added the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Sep 20, 2020
@lbartoletti
Copy link
Member

BTW, there is the same problem with M point. So you may add this in fcnGeomM

if ( !geom.constGet()-> isMeasure() )
    return QVariant();

@pblottiere
Copy link
Member Author

BTW, there is the same problem with M point.

Thanks for the input @lbartoletti, I take a look.

@pblottiere pblottiere removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Sep 28, 2020
@pblottiere pblottiere merged commit 9cf95ff into qgis:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

z function returns Nan when used with a 2d point geometry
3 participants
@pblottiere @lbartoletti @nyalldawson