Fix PG trust metadata layer loading #38833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
Data Provider
|
Perfect - I confirm that it fixes my issue!
Thanks a lot,
Andreas
On 2020-09-17 13:04, Alessandro Pasotti wrote:
Fixes #38809 [1]
Followup 760347c [2]
-------------------------
YOU CAN VIEW, COMMENT ON, OR MERGE THIS PULL REQUEST ONLINE AT:
#38833
COMMIT SUMMARY
* Fix PG trust metadata layer loading
FILE CHANGES
* M src/core/qgsvectorlayer.cpp [3] (2)
* M src/providers/postgres/qgspostgresprovider.cpp [4] (4)
* M tests/src/python/test_provider_postgres.py [5] (37)
PATCH LINKS:
* https://github.com/qgis/QGIS/pull/38833.patch
* https://github.com/qgis/QGIS/pull/38833.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [6], or unsubscribe [7].
Links:
------
[1] #38809
[2]
760347c
[3]
https://github.com/qgis/QGIS/pull/38833/files#diff-106be592650b55ccae79c83eecd15ceb
[4]
https://github.com/qgis/QGIS/pull/38833/files#diff-374a3d3ebe5430cec252d7f2c7d5f457
[5]
https://github.com/qgis/QGIS/pull/38833/files#diff-99b101819133a316786604243f3abf6e
[6] #38833
[7]
https://github.com/notifications/unsubscribe-auth/AAGX57EMZBGWRL3HVTXW5HTSGHUKHANCNFSM4RQIFFOQ
|
Fixes qgis#38809 Followup 760347c
elpaso
force-pushed
the
bugfix-gh38809-pg-trust-epic-fail
branch
from
c6dcc64
to
9d436cd
Compare
rldhont
reviewed
Sep 17, 2020
| @@ -1544,7 +1544,7 @@ bool QgsVectorLayer::readXml( const QDomNode &layer_node, QgsReadWriteContext &c | |||
| } | |||
|
|
|||
| QgsDataProvider::ProviderOptions options { context.transformContext() }; | |||
| QgsDataProvider::ReadFlags flags = QgsDataProvider::ReadFlags(); | |||
| QgsDataProvider::ReadFlags flags; | |||
There was a problem hiding this comment.
The generated code is totally equivalent, I just find redundant call the default ctor explicitly. It's more a style matter, nothing important.
There was a problem hiding this comment.
@rldhont np.
On another topic I did not check if the same quotedIdentifier / quotedValue mistake was done elsewhere with your original PR or any followup. Can you please check that it only affected PG?
nyalldawson
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38809
Followup 760347c