Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide splash screen when loading the project #38842

Merged
merged 1 commit into from
Sep 18, 2020
Merged

hide splash screen when loading the project #38842

merged 1 commit into from
Sep 18, 2020

Conversation

PeterPetrik
Copy link
Contributor

@PeterPetrik PeterPetrik commented Sep 17, 2020 •
edited
Loading

fix #27051
fix #34784

I am not sure this is correct fix, since now the splash screen is not visible during project load even there are no broken layers.

  • Maybe better to not show it once hidden?
  • Or somehow pass splash object to QgsHandleBadLayersHandler::handleBadLayers and temporary hide it there?

@github-actions github-actions bot added this to the 3.16.0 milestone Sep 17, 2020
@nyalldawson
Copy link
Collaborator

I think this is OK -- I don't see an issue with closing the splash screen when the project starts loading, by that stage we will already have the application window constructed and providing feedback regarding the project load progress...

@PeterPetrik
Copy link
Contributor Author

so @nyalldawson you suggest to not show() it afterwards, just hide?

@nyalldawson
Copy link
Collaborator

Yep. It probably made sense a while back, but now we show project load progress reports in the main window

@nyalldawson nyalldawson merged commit 640f046 into qgis:master Sep 18, 2020
@PeterPetrik PeterPetrik deleted the fix_27051_splash_screen_block branch October 19, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
2 participants
@PeterPetrik @nyalldawson