fix QgsDualEdgeTriangulation #38867
Merged
fix QgsDualEdgeTriangulation #38867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcloarec
added
Bug
nyalldawson
reviewed
Sep 19, 2020
| @@ -204,7 +205,22 @@ int QgsDualEdgeTriangulation::addPoint( const QgsPoint &p ) | |||
| int point1 = mHalfEdge[mEdgeOutside]->getPoint(); | |||
| int point2 = mHalfEdge[mHalfEdge[mEdgeOutside]->getDual()]->getPoint(); | |||
| double distance1 = p.distance( *mPointVector[point1] ); | |||
| if ( distance1 <= leftOfTresh ) // point1 == new point | |||
| { | |||
| QgsPoint *pt = mPointVector.last(); | |||
There was a problem hiding this comment.
Suggested change
| QgsPoint *pt = mPointVector.last(); | |
| delete mPointVector.takeLast(); |
Etc
|
Any chance of a test for this too? |
|
yes... this could be a good think, I was thinking about... |
|
new tests added, and another issue fixed... |
nyalldawson
approved these changes
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another issue in the dual edge triangulation (described here : #30549 (comment)), and still present with recent fix.
This PR fixes it.