Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume iface is available #38900

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

nyalldawson
Copy link
Collaborator

E.g. in qgis_process iface is None

Fixes #38862

E.g. in qgis_process iface is None

Fixes qgis#38862
@nyalldawson nyalldawson added Processing Relating to QGIS Processing framework or individual Processing algorithms backport release-3_10 labels Sep 21, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 21, 2020
@nyalldawson nyalldawson merged commit 772181b into qgis:master Sep 21, 2020
@nyalldawson nyalldawson deleted the fix_38862 branch September 21, 2020 02:05
@alexbruy
Copy link
Contributor

Oh, you are faster. I was about to submit fix for this. But your approach looks better than mine.

@nyalldawson
Copy link
Collaborator Author

@alexbruy it's a temporary fix -- for 3.18 i'd thinking of pulling apart processing into multiple separate components/plugins:

  • qgis python algs
  • gdal provider
  • saga provider
    -grass provider
    -otb provider
  • processing "core" (the remaining python bits required for processing to run, e.g. model provider + script provider)
  • processing "gui" -- all the stuff which requires iface, such as the toolbox, model designer, etc.

The intention then would be that for 4.0 we'd drop processing "core" (it'd all be in c++), and if possible at that stage processing "gui" too.

What do you think?

@alexbruy
Copy link
Contributor

I'm fully agree that Processing should become a core component of QGIS. Only providers will remain plugin. So I'm a big +1 here.

@m-kuhn
Copy link
Member

m-kuhn commented Sep 24, 2020

At the same time, could we update plugin init methods to

  • initGui() called by app
  • initCore() called by app, process, server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qgis_process list raises exception if processing algorithm provider is activated
3 participants