Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VirtualLayer] Catch exception while updating virtual layer stats #38949

Merged
merged 2 commits into from
Sep 24, 2020
Merged

[VirtualLayer] Catch exception while updating virtual layer stats #38949

merged 2 commits into from
Sep 24, 2020

Conversation

troopa81
Copy link
Contributor

Description

Fixes #34378 : Uncaught exception was breaking QGIS

@troopa81 troopa81 added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers labels Sep 22, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 22, 2020
@elpaso
Copy link
Contributor

elpaso commented Sep 22, 2020

@troopa81 LGTM.

Not related at all but I was wondering if there a reason why this class is using its own QSqlite interface instead of the QgsSqliteUtils ?

@troopa81
Copy link
Contributor Author

Not related at all but I was wondering if there a reason why this class is using its own QSqlite interface instead of the QgsSqliteUtils ?

QgsSqliteUtils (added in 2017) didn't not exist when Virtual layer feature was added (in 2015). I don't see any other reason for virtual layer to not use the same interface.

@troopa81
Copy link
Contributor Author

Thanks for review @elpaso

@troopa81 troopa81 force-pushed the fix_virtuallayer_statsexception branch from 63058ca to 7c88004 Compare September 22, 2020 15:13
@nyalldawson
Copy link
Collaborator

Can you rebase and fix the merge conflict please?

@troopa81 troopa81 force-pushed the fix_virtuallayer_statsexception branch from 7c88004 to 86add3a Compare September 23, 2020 09:40
@troopa81
Copy link
Contributor Author

Can you rebase and fix the merge conflict please?

Done

@nyalldawson nyalldawson merged commit f3a5b69 into qgis:master Sep 24, 2020
@qgis-bot qgis-bot mentioned this pull request Sep 24, 2020
Closed
@troopa81 troopa81 mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Error in SQL statement for Virtual layers may lock layers in map canvas
3 participants
@troopa81 @elpaso @nyalldawson