Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect scale lock when panning the map #38954

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Respect scale lock when panning the map #38954

merged 3 commits into from
Sep 23, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 22, 2020 •
edited
Loading

Fixes #38953 and #38417

@elpaso elpaso added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 22, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 22, 2020
@nyalldawson
Copy link
Collaborator

Would you mind adding a test for this? We don't have much test coverage of the map canvas methods (they've been around forever and easily predate the current test-focused mindset).

@nyalldawson
Copy link
Collaborator

(fix looks good though!)

@elpaso elpaso added the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Sep 23, 2020
@elpaso elpaso force-pushed the bugfix-gh38953-scale-lock-ignored-when-panning branch from 97bd7a4 to 75efa28 Compare September 23, 2020 11:12
@elpaso
Copy link
Contributor Author

elpaso commented Sep 23, 2020 •
edited
Loading

@nyalldawson I took a different route and hopefully fixed a series of bugs with scale locking. Tests added as well.

@elpaso elpaso force-pushed the bugfix-gh38953-scale-lock-ignored-when-panning branch from fbcd751 to 75efa28 Compare September 23, 2020 12:37
nyalldawson
nyalldawson approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@nyalldawson nyalldawson merged commit c1702db into qgis:master Sep 23, 2020
@elpaso elpaso deleted the bugfix-gh38953-scale-lock-ignored-when-panning branch September 24, 2020 05:42
@elpaso elpaso mentioned this pull request Sep 24, 2020
Closed
@lbell lbell mentioned this pull request Apr 17, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Requires Tests! Waiting on the submitter to add unit tests before eligible for merging
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

Scale lock is ignored when panning the map
2 participants
@elpaso @nyalldawson