Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up cache geometry if HTML widget needs it #39041

Closed
wants to merge 5 commits into from
Closed

Set up cache geometry if HTML widget needs it #39041

wants to merge 5 commits into from

Conversation

troopa81
Copy link
Contributor

Description

Fixes #34791 : It's possible to define a geometry based expression in HTML widget, but it the vector layer cache doesn't require geometry the expression will fail. This PR propose to run an html rendering to guess if the expression needs the geometry and then set up the cache geometry option on the vector layer cache.

Pretty sure same issue happen to QML widget. I'll create an issue and a separate PR for this one.

@github-actions github-actions bot added this to the 3.16.0 milestone Sep 25, 2020
@troopa81 troopa81 added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Oct 16, 2020
@nyalldawson nyalldawson modified the milestones: 3.16.0, 3.18 (Feature) Oct 23, 2020
@stale
Copy link

stale bot commented Nov 7, 2020

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 7, 2020
@troopa81 troopa81 removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 12, 2020
@troopa81
Copy link
Contributor Author

@elpaso Do you mind reviewing this PR, as you were the one who initially add the HTML widget?

@troopa81 troopa81 requested a review from elpaso December 3, 2020 13:14
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 23, 2020
@troopa81
Copy link
Contributor Author

don't stale

@troopa81 troopa81 removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 28, 2020
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 12, 2021
@troopa81 troopa81 removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 12, 2021
@nyalldawson nyalldawson modified the milestones: 3.18 (Feature), 3.18.0 Jan 16, 2021
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 31, 2021
@troopa81
Copy link
Contributor Author

troopa81 commented Feb 4, 2021

I rebased, could someone review and merge this PR ?

@troopa81 troopa81 added backport release-3_16 and removed stale Uh oh! Seems this work is abandoned, and the PR is about to close. backport release-3_16 labels Feb 4, 2021
@troopa81
Copy link
Contributor Author

Rebase and all green!

@nyalldawson nyalldawson added the Frozen Feature freeze - Do not merge! label Feb 17, 2021
@nyalldawson nyalldawson modified the milestones: 3.18.0, 3.18.1 Feb 19, 2021
@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Feb 19, 2021
@nyalldawson nyalldawson added NOT FOR MERGE Don't merge! and removed NOT FOR MERGE Don't merge! labels Feb 27, 2021
@nyalldawson nyalldawson reopened this Feb 28, 2021
@troopa81
Copy link
Contributor Author

troopa81 commented Mar 8, 2021

Could someone review and merge this long standing PR please ? Thank you in advance

@Houska1
Copy link
Contributor

Houska1 commented Mar 15, 2021

As the reporter of the bug that @troopa81 seems to have fixed, another vote of encouragement to get this reviewed and merged! Thanks

@nyalldawson nyalldawson modified the milestones: 3.18.1, 3.20.0 Mar 19, 2021
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 4, 2021
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 12, 2021
@troopa81 troopa81 mentioned this pull request Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso Awaiting requested review from elpaso

Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.20.0
Development

Successfully merging this pull request may close these issues.

Form fails to initialize $geometry
3 participants
@troopa81 @Houska1 @nyalldawson