Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG fix relation discovery with table/schema that require quotes #39043

Merged
merged 4 commits into from
Oct 1, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 25, 2020

Fixes #39036 #39025 (temptative, because I could not reproduce the
exact issue without project and data)

Fixes qgis#39036 qgis#39025  (temptative, because I could not reproduce the
exact issue without project and data)
@elpaso elpaso added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Sep 25, 2020
@elpaso elpaso closed this Sep 25, 2020
@elpaso elpaso reopened this Sep 25, 2020
@github-actions github-actions bot added this to the 3.16.0 milestone Sep 25, 2020
@elpaso
Copy link
Contributor Author

elpaso commented Sep 25, 2020

@3nids I need a little help here: I added sql to the badlist here dfb8527 but apparently it has no effect.

@3nids
Copy link
Member

3nids commented Sep 25, 2020

Rather than removing check for all sql files, you can add a #spellok on the concerned line (in a comment)
I'd prefer keeping spell check on as many files as possible.

@elpaso
Copy link
Contributor Author

elpaso commented Sep 25, 2020

@3nids On all lines? It's not even one of my files. Besides that it is an sql test data. Is there at least a file block list?

@3nids
Copy link
Member

3nids commented Sep 25, 2020

@elpaso
Copy link
Contributor Author

elpaso commented Sep 25, 2020

@3nids thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erroneous postgis query when trying to discover relations
2 participants