Improve multicolumn legend layout #39052
Merged
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change leads to a different output for the Old behaviour: New behaviour: The new layout is less tall than the old result, while still respecting the manual column breaks. I think that the new behavior is preferable. |
jdugge
force-pushed
the
multicolumn_legend_balancing
branch
from
ea0c64e
to
6082d00
Compare
jdugge
changed the title
|
Great, thank you! Missed this much better behaviour. |
|
Nice fix! I agree about the reference image -- can you update this so that the tests pass again? |
|
@nyalldawson Done |
nyalldawson
approved these changes
Oct 5, 2020
|
Thanks @jdugge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct calculation of target column heights in multicolumn legends
Multicolumn legends sometimes have uneven column lengths even in cases where equally sized columns would be possible. This is caused by the fact that the heuristic currently calculates the target column height by summing the height of all legend items including the space between items and dividing it by the number of columns, without taking into account that the first item in each column has no space above it.
This pull request corrects this behavior by reducing the total height of all legend items by the inter-item space that is not required due to the column breaks.
Fixes #37417