Commit data on scale changed for advanced snap configuration min/max scale #39133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
Bug
|
@troopa81 I don't think there was a specific reason. If you replace it by the combobox directly with no issue, you can probably also replace it in QgsSnappingWidget for the global min/max scale. |
configuration min/max scale
troopa81
force-pushed
the
fix_snapconfigscale_commitdata
branch
from
13cc874
to
3a19d56
Compare
|
@obrix I guess I was wrong, replacing QgsScaleWidget with QgsScaleComboBox breaks the advanced snapping configuration flotatting window (though it's the same widgets). So I keep the QgsScaleWidget and just add the fix for the model update. |
nyalldawson
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #39031 : commitData signal must be sent so the item view is aware that model needs to be updated
@obrix Is there any special reason why you use a QgsScaleWidget instead of a QgsScaleComboBox. The former just adds a button to get current scale from canvas but was not set as visible.