fix inserting break lines in dual edge triangulation #39218
Conversation
vcloarec
added
Bug
| @@ -1327,13 +1327,39 @@ unsigned int QgsDualEdgeTriangulation::insertEdge( int dual, int next, int point | |||
|
|
|||
| } | |||
|
|
|||
| static bool triangleIsFlat( const QgsPoint &pt1, const QgsPoint &pt2, const QgsPoint &pt3, double tolerance ) | |||
There was a problem hiding this comment.
Maybe this method could be useful in QgsTriangle class?
There was a problem hiding this comment.
Or in QgsGeometryUtils to avoid the creation of a triangle each time
There was a problem hiding this comment.
Ad this function is not complete (but sufficient in this context), no sure. Indeed, only the distance between the segment [pt1,pt2] from pt3 is checked. So if this segment is very small and pt3 far away, the triangle is flat but the function does not return true.
This is acceptable here and changing that will slow down the function. I think I will change the function name / add comments.
|
@nyalldawson , also pretty tricky to fix... |
|
I can imagine! I'm just glad that these classes are getting some love and no longer produce embarrassing results!! |
fix #30549 and more generally inserting break line in dual edge triangulation.
Hope it is the last issue... (surely not!)