Try to make PROJ >= 6 related tests more robust to output from different PROJ versions #39290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent PROJ versions
nyalldawson
reviewed
Oct 9, 2020
|
|
||
| QgsPointXY pp( 529127, 479348 ); | ||
| pp = ct.transform( pp ); | ||
| QGSCOMPARENEAR( pp.x(), 679125.816475, 0.00001 ); |
There was a problem hiding this comment.
yes recent PROJ returns a default pipeline that is slightly different from previously. None of them are necessarily better (user choice required), hence the choice for a transformation that should hopefully be stable among all PROJ versions and not dependent on content of the EPSG database
nyalldawson
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.