Split with lines fixes #39353
Merged
Split with lines fixes #39353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…section test in Split With Lines algorithm
an endless loop if geos difference result is numerically unstable Amend the test to determine whether a split occurred from an exact topological test to instead test with a very small tolerance. This avoids us flagging that a split has occurred when the actual results have only varied by a insignificant amount due to precision of the GEOS difference op. This fixes a hang which can otherwise result where we keep splitting the same pair of lines and think that a change is occurring every time.
nyalldawson
force-pushed
the
split_with_lines
branch
from
0861f7c
to
45e9501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Split with lines" algorithm can get stuck in an endless loop if geos difference result is numerically unstable.
Amend the test to determine whether a split occurred from an exact topological test to instead test with a very small tolerance. This avoids us flagging that a split has occurred when the actual results have only varied by a insignificant amount due to precision of the GEOS difference op.
This fixes a hang which can otherwise result where we keep splitting the same pair of lines and think that a change is occurring every time.
Also a minor optimisation to avoid a redundant intersection test which we've already done.