Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly determine if variables are static in aggregate expression and filter, give @parent in generic aggregates #39391

Merged
merged 5 commits into from
Oct 16, 2020
Merged

correctly determine if variables are static in aggregate expression and filter, give @parent in generic aggregates #39391

merged 5 commits into from
Oct 16, 2020

Conversation

3nids
Copy link
Member

@3nids 3nids commented Oct 15, 2020

fixes #33382

@3nids 3nids requested a review from nirvn October 15, 2020 12:46
@github-actions github-actions bot added this to the 3.16.0 milestone Oct 15, 2020
nirvn
nirvn approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and elegant.

@3nids 3nids changed the title correctly determine if variables are static in aggregate expression and filter correctly determine if variables are static in aggregate expression and filter, give @parent in generic aggregates Oct 15, 2020
@nyalldawson nyalldawson merged commit 0170436 into qgis:master Oct 16, 2020
@3nids 3nids deleted the fix33382 branch October 16, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

aggregates inside with_variable gives incorrect result
3 participants
@3nids @nirvn @nyalldawson