show field alias when presenting constraint msg #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice change! Better use |
|
🥇 |
Before, when a field didn't passed the defined constraints it showed a message in the form of "field name: Constraint defined message". Now, if if a field alias is defined, the message is in the form of "field alias: Constraint defined message" See qgis#15455
tudorbarascu
force-pushed
the
field-alias
branch
from
0e8e793
to
1399bce
Compare
|
Thanks for the guidance guys! |
|
Thanks for the good work! |
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
Dec 10, 2018
The new QgsRenderContext::TextRenderFormat enum controls how text should be handled during a render operation, e.g. whether to render text as outlines (paths) or keep it as real text objects. Deprecate previous arguments in QgsTextRenderer which handled this same use case. This allows us to make the setting vary per-render, instead of having a single global flag controlling the setting. Ultimately this will allow us to have different behaviour within the canvas renders vs print layout exports. Refs qgis#3975
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
Dec 10, 2018
nyalldawson
added a commit
that referenced
this pull request
Dec 11, 2018
The new QgsRenderContext::TextRenderFormat enum controls how text should be handled during a render operation, e.g. whether to render text as outlines (paths) or keep it as real text objects. Deprecate previous arguments in QgsTextRenderer which handled this same use case. This allows us to make the setting vary per-render, instead of having a single global flag controlling the setting. Ultimately this will allow us to have different behaviour within the canvas renders vs print layout exports. Refs #3975
nyalldawson
added a commit
that referenced
this pull request
Dec 11, 2018
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
Dec 11, 2018
The new QgsRenderContext::TextRenderFormat enum controls how text should be handled during a render operation, e.g. whether to render text as outlines (paths) or keep it as real text objects. Deprecate previous arguments in QgsTextRenderer which handled this same use case. This allows us to make the setting vary per-render, instead of having a single global flag controlling the setting. Ultimately this will allow us to have different behaviour within the canvas renders vs print layout exports. Refs qgis#3975 (cherry picked from commit 53345c3)
nyalldawson
added a commit
that referenced
this pull request
Dec 11, 2018
The new QgsRenderContext::TextRenderFormat enum controls how text should be handled during a render operation, e.g. whether to render text as outlines (paths) or keep it as real text objects. Deprecate previous arguments in QgsTextRenderer which handled this same use case. This allows us to make the setting vary per-render, instead of having a single global flag controlling the setting. Ultimately this will allow us to have different behaviour within the canvas renders vs print layout exports. Refs #3975 (cherry picked from commit 53345c3)
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when a field didn't passed the defined constraints
it showed a message in the form of "field name: Constraint defined message".
Now, if if a field alias is defined, the message is in the form of
"field alias: Constraint defined message"
I see it was already described at https://hub.qgis.org/issues/15455