Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Enable WFS-T for 2.0.0 and 1.1.0 Fixes #15597 #3989

Merged
merged 1 commit into from
Jan 14, 2017

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 13, 2017

Tested on GeoServer and QGIS Server

Needs forward port to master

@elpaso elpaso requested a review from rouault January 13, 2017 17:54
@rouault
Copy link
Contributor

rouault commented Jan 13, 2017

Huh is that all what is needed for WFS-T 1.1 and 2.0 ? Just a small update when parsing capabilities ?

Ah, I see: you must still do WFS-T 1.0 for the Transaction operation. In which case this is not really WFS-T 1.1 and 2.0. The commit message should reflect that since that means that a server that would just implement WFS-T 1.1 or 2.0 wouldn't work.

@elpaso
Copy link
Contributor Author

elpaso commented Jan 13, 2017

Yes, the transactional part is still 1.0. I'll amend the commit message. BTW the default version "auto" will now work with most of GeoServer installations without the need to manually set 1.0.

@rouault
Copy link
Contributor

rouault commented Jan 14, 2017

Didn't you experience issues when doing the Transaction part in WFS-T 1.0 and thus getting 'fid' attributes when creating a feature, and the GetFeature part in WFS 1.1/2.0 getting a 'gml:id'. fid are typically just numerical values whereas gml:id is generally feature_type_name.serial_number. That could lead to duplicated features.

@elpaso
Copy link
Contributor Author

elpaso commented Jan 14, 2017

I'm not yet at it and I'm now adding tests for WFS-T 2.0.0, I realize that this is only a partial fix.
Are the duplicated features generated on insert only or also on update?

@elpaso
Copy link
Contributor Author

elpaso commented Jan 14, 2017

@rouault It seems that the WFS-T with GeoServer has severe issues in current 2.18 and master even if I manually set 1.0.0, see here: http://hub.qgis.org/issues/16043#note-5

Tested on GeoServer and QGIS Server

Needs forward port to master
@elpaso elpaso merged commit 93770b1 into qgis:release-2_18 Jan 14, 2017
@elpaso elpaso deleted the wfst-200-fix-15597 branch January 14, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants