Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server landing page: support for scale #40254

Merged
merged 3 commits into from Nov 27, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Nov 24, 2020

and scale dependent symbology in the legend

qgis-server-landing-page-scale

Details are here: https://github.com/elpaso/qgis-server-landing-page-plugin/commits/master

and scale dependent symbology in the legend
@elpaso elpaso added the Server Related to QGIS server label Nov 24, 2020
@github-actions github-actions bot added this to the 3.18.0 milestone Nov 24, 2020
@nyalldawson
Copy link
Collaborator

@elpaso I just noticed in the screencast the advertisement for QCooperative -- is this really appropriate? It's opening a horrible can of worms where the precedent is set for other developers to insert ads for their organisations in parts of QGIS (ie. click on add point cloud layer, see an ad for Lutra!).

@NathanW2
Copy link
Member

@elpaso I haven't been following this development much but just wondering why the source isn't committed and only the built and minified versions? Just haven't moved them yet?

@elpaso
Copy link
Contributor Author

elpaso commented Nov 26, 2020

@elpaso I just noticed in the screencast the advertisement for QCooperative -- is this really appropriate? It's opening a horrible can of worms where the precedent is set for other developers to insert ads for their organisations in parts of QGIS (ie. click on add point cloud layer, see an ad for Lutra!).

Yeah, you are right I'll remove it. The fact is that it started as a plugin and I still use the plugin for developing the front-end: https://github.com/elpaso/qgis-server-landing-page-plugin, I didn't think about removing the footer, I'll leave the heart if you don't mind.

@elpaso
Copy link
Contributor Author

elpaso commented Nov 26, 2020

@elpaso I haven't been following this development much but just wondering why the source isn't committed and only the built and minified versions? Just haven't moved them yet?

I have no objections to copy the sources to QGIS repo. What was blocking me so far is the build system and to maintain a copy of the sources, you are actually not the first one who asked.

Ideally we should keep only the sources in the QGIS repo and setup the JS build system which is the hard part, I've had no time for that and honestly since this was 100% volunteer work and I'm not using it myself I was hoping for someone (is there any JS developer out there?) to step in and help with that.

But I'm starting to consider the option that maybe it would be better to just drop the whole landing page from QGIS core and leave it as an independent plugin.

@elpaso
Copy link
Contributor Author

elpaso commented Nov 26, 2020

@NathanW2 just to be clear, I would be more that happy if you could help with the JS code integration into the QGIS build system.

@elpaso elpaso merged commit ce916ea into qgis:master Nov 27, 2020
@elpaso elpaso deleted the server-landingpage-scale-support branch November 27, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants