Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLD parsing: handling ogc:Literal within CssParameter - backport 2.18 #4034

Merged
merged 4 commits into from Jan 23, 2017
Merged

SLD parsing: handling ogc:Literal within CssParameter - backport 2.18 #4034

merged 4 commits into from Jan 23, 2017

Conversation

rldhont
Copy link
Contributor

@rldhont rldhont commented Jan 22, 2017

Backport PR #3996 to release 2.18

@rldhont rldhont added this to the 2.18 milestone Jan 22, 2017
@rldhont
Copy link
Contributor Author

rldhont commented Jan 22, 2017

Hi @jgrocha, @luipir, @aaime this the backport.

@aaime
Copy link
Contributor

aaime commented Jan 22, 2017

The backport looks reasonable to me, and yet there are two build failures:

The following tests FAILED:
	  7 - qgis_indentation (Failed)
	229 - PyQgsSymbolLayerReadSld (Failed)

@rldhont rldhont force-pushed the sld-backport-release-2_18-parsing branch from 514a982 to 5ed0607 Compare January 22, 2017 15:39
@rldhont rldhont force-pushed the sld-backport-release-2_18-parsing branch from 5ed0607 to dfdec0f Compare January 22, 2017 16:03
@rldhont
Copy link
Contributor Author

rldhont commented Jan 22, 2017

@aaime thanks and fixed

@rldhont rldhont merged commit 1746b32 into qgis:release-2_18 Jan 23, 2017
@rldhont rldhont mentioned this pull request Jan 23, 2017
Merged
@rldhont rldhont deleted the sld-backport-release-2_18-parsing branch January 2, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Backporting
Projects
None yet
Milestone
2.18.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rldhont @aaime @jgrocha