Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PG raster after 787181ad #40521

Merged
merged 1 commit into from Dec 9, 2020
Merged

Fix PG raster after 787181ad #40521

merged 1 commit into from Dec 9, 2020

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Dec 9, 2020

Fixes #40515

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_16 BROKEN - YOU MUST DIY!!! labels Dec 9, 2020
@github-actions github-actions bot added this to the 3.18.0 milestone Dec 9, 2020
@jgrocha
Copy link
Member

jgrocha commented Dec 9, 2020

Tested and working (rasters in-db, out-of-db; with and without overlays). Can be merged IMHO.

Maybe we could improve postgis raster tests, because rasters were failing after 787181a. The tests should have prevent this regression. Can be done later.

Thanks @elpaso for his quick fix. You are the best!

@elpaso
Copy link
Contributor Author

elpaso commented Dec 9, 2020

Tested and working (rasters in-db, out-of-db; with and without overlays). Can be merged IMHO.

Maybe we could improve postgis raster tests, because rasters were failing after 787181a. The tests should have prevent this regression. Can be done later.

The tests are already implemented, unfortunately they are not running on Travis because they have been disabled (because they were randomly failing with no reason).

Thanks @elpaso for his quick fix. You are the best!

Not sure about that: I should have remembered that the test were disabled on Travis and I should have run them locally 😞

@elpaso elpaso merged commit d958dfe into qgis:master Dec 9, 2020
@elpaso elpaso deleted the bugfix-gh40515-pgraster-regression branch December 9, 2020 14:48
elpaso added a commit that referenced this pull request Dec 9, 2020
@elpaso
[backport] Fix PG raster after 787181a
ad0a3bd 
Fixes #40515

Manual backport of #40521
@elpaso elpaso mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

Postgis rasters broken in master
2 participants
@elpaso @jgrocha