Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DB2 provider #40930

Closed
wants to merge 1 commit into from
Closed

Remove DB2 provider #40930

wants to merge 1 commit into from

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 10, 2021

QGIS just got a new proprietary-based provider, so for balance, let's get rid of
an existing one.
The original committer of the DB2 provider hasn't been active for more than 2 years,
and all activity in the provider since then has been, as far as I can see,
forced maintenance, due to changes elsewhere in the code base.

https://github.com/qgis/QGIS/issues?q=is%3Aissue+db2 shows that only one ticket
has been created specifically regarding the DB2 provider. This is either a sign
it is of the highest quality, but more realisticly than hardly anybody is using it,
otherwise there would be feature requests regarding it.

I don't see IBM as a sustaining member of QGIS.org, so it is hard to justify
maintenance costs due to it.

@rouault rouault force-pushed the remove_db2 branch 2 times, most recently from cf4c8ed to 4e23455 Compare January 10, 2021 17:34
@github-actions github-actions bot added this to the 3.18.0 milestone Jan 10, 2021
@nyalldawson
Copy link
Collaborator

As much as I'd love to, I don't think we can do this without any warning to users. We should first create a qep and then put out a notice in the news feed to get feedback from users.

@rouault
Copy link
Contributor Author

rouault commented Jan 10, 2021

put out a notice in the news feed

how can I do that ?

rouault added a commit to rouault/gdal that referenced this pull request Jan 10, 2021
For consistency and pretty much the same reasons as
qgis/QGIS#40930
@nyalldawson nyalldawson added the NOT FOR MERGE Don't merge! label Jan 10, 2021
@nyalldawson
Copy link
Collaborator

Tagging as "not for merge", pending outcome of qgis/QGIS-Enhancement-Proposals#204

@nyalldawson
Copy link
Collaborator

how can I do that ?

Ask on the PSC list

@dwadler
Copy link
Contributor

dwadler commented Jan 11, 2021

I don't think it is right that DB2 has been removed without any discussion.

@gioman
Copy link
Contributor

gioman commented Jan 11, 2021

I don't think it is right that DB2 has been removed without any discussion.

@dwadler this PR has not been merged.

@dwadler
Copy link
Contributor

dwadler commented Jan 11, 2021

I don't think it is right that DB2 has been removed without any discussion.

@dwadler this PR has not been merged.

OK - I was just looking at the commit - which hasn't been merged.

@roya0045
Copy link
Contributor

Could it be made 'optional' such as moving it to a plugin?

@rouault
Copy link
Contributor Author

rouault commented Jan 12, 2021

Could it be made 'optional' such as moving it to a plugin?

Such driver would certainly a perfect fit for a plugin (like the HANA one which shouldn't have made its way to core), and if the plugin architecture isn't fit, the contribution should be to improve it. No need to clutter the UI and code base with something that is only marginally used. QGIS should be careful not becoming the kitchen sink that GDAL is (one could argue that GDAL mission is to be a kitchen sink, but I'm starting to question this).

@rouault rouault force-pushed the remove_db2 branch 2 times, most recently from cafa889 to e5a451a Compare January 12, 2021 18:04
@dwadler
Copy link
Contributor

dwadler commented Jan 12, 2021

I haven't looked at the plug-in architecture enough to know whether and how it would work with a database source provider.
If the plug-in API isn't adequate, the base functionality shouldn't be removed until the API is adequate and time is allowed to re-implement the functionality.
Before functionality is removed from a product / project, isn't there usually a notice of deprecation and removal in a subsequent release?

QGIS just got a new proprietary-based provider, so for balance, let's get rid of
an existing one.
The original committer of the DB2 provider hasn't been active for more than 2 years,
and all activity in the provider since then has been, as far as I can see,
forced maintenance, due to changes elsewhere in the code base.

https://github.com/qgis/QGIS/issues?q=is%3Aissue+db2 shows that only one ticket
has been created specifically regarding the DB2 provider. This is either a sign
it is of the highest quality, but more realisticly than hardly anybody is using it,
otherwise there would be feature requests regarding it.

I don't see IBM as a sustaining member of QGIS.org, so it is hard to justify
maintenance costs due to it.
@nyalldawson
Copy link
Collaborator

Following #41178, let's close this as we've effectively removed the provider for most users anyway. Then in 3.20/.22 we can revisit a complete removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT FOR MERGE Don't merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants