fix QgsProject::readNumEntry() validity check #4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(ping @nyalldawson , @m-kuhn ) |
|
Looks good! Can you add a unit test covering this? |
nirvn
force-pushed
the
project_tiny_fix
branch
from
d811306
to
bd270e6
Compare
nirvn
force-pushed
the
project_tiny_fix
branch
from
bd270e6
to
fc1941d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halfway through debugging a project load issue, I've stumbled on a tiny issue with the QgsProject::readNumEntry(), whereas it wrongly validates for a string conversion when it should check for an int one.
Not the end of the world, but we might as well fix this.