Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB2: tweak labels (in debug builds) to reflect status #41142

Merged
merged 1 commit into from Jan 25, 2021

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 23, 2021

No description provided.

@github-actions github-actions bot added this to the 3.18.0 milestone Jan 23, 2021
@nyalldawson
Copy link
Collaborator

Could you ifdef this in only for debug builds? Just so we don't leave in place for final release

@rouault
Copy link
Contributor Author

rouault commented Jan 23, 2021

Just so we don't leave in place for final release

Are qgis master nightly builds debug or release ? If it isn't visible by at least some end users, then this PR is useless :-)

@nyalldawson
Copy link
Collaborator

ifdef QGIS_DEBUG should be true for nightlies, not for release

@rouault rouault changed the title DB2: tweak labels to reflect status DB2: tweak labels (in debug builds) to reflect status Jan 25, 2021
@rouault rouault merged commit 13ed787 into qgis:master Jan 25, 2021
@roya0045
Copy link
Contributor

Just an idea, but would it be good to set it in yellow and add a tooltip (for the one in the browser) and another information thing for the dialog stating that this provider is considered for removal? I'm not sure if this is a good move for releases but I recall that this was done in processing to some extent.

@rouault
Copy link
Contributor Author

rouault commented Jan 25, 2021

Just an idea, but would it be good to set it in yellow and add a tooltip (for the one in the browser)

Maybe, but I just don't want to spend any more second on this. I've already burnt much too energy on this.

@roya0045
Copy link
Contributor

@rouault I can understand, no worries. This was in the event of a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants