Fix "Avoid artifacts when project is rendered as map tiles" doesn't work on server #41229
Conversation
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
the
stale
settings, that's not a stable place to store things like this which are designed to apply in both desktop and server contexts! Refs qgis#37679
a project using WMS services Fixes qgis#37679
Returns true if the symbol layer rendering can cause visible artifacts across a single feature when the feature is rendered as a series of adjacent map tiles each containing a portion of the feature's geometry. This depends on the symbol layer derived class itself - eg a simple solid color fill won't show any artifacts, but a shapeburst fill WILL.
Returns True if ANY of the symbol layers contained in the symbol can cause tile rendering artifacts
…s of the RenderMapTile flag
Instead of force disabling ALL feature clipping to rendered map bounds (which is INCREDIBLY expensive to disable, and can result in slooow map renders), be more intelligent and only disable the feature clipping for symbols where we know there'll be visible map tile artifacts between neighbouring tiles. If there's not going to be any artifacts (eg the symbol is a solid color fill), then it's pointless to disable the huge speed boost we get from the automatic geometry clipping...
nyalldawson
force-pushed
the
fix_37679_server_tile
branch
from
d183dd4
to
c6a70ca
Compare
nyalldawson
removed
the
stale
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-41229-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 22a4b881d383dc0811d0b7230760758bbffdb26f
# Push it to GitHub
git push --set-upstream origin backport-41229-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16Then, create a pull request where the |
Fixes #37679