Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server WFS: handle axis orientation #41242

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Jan 28, 2021

Fixes #36584

Try to fix the canonical mess with axis order for server WFS-T, I'm following the convention used by GeoServer [1] but I'm not really sure I'm getting this right, there are a bunch of tests with the 4 different ways to specify a srsName I could think of.

The bottom line is that 1.0.0 and 1.1.1 with this patch are behaving the same way:

  • EPSG:4326 -> LON-LAT
  • http://www.opengis.net/gml/srs/epsg.xml#4326 -> LON-LAT
  • urn:ogc:def:crs:EPSG::4326 -> LAT-LON
  • http://www.opengis.net/def/crs/EPSG/0/4326 -> LAT-LON

[1] https://docs.geoserver.org/latest/en/user/services/wfs/axis_order.html#wfs-basics-axis

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server labels Jan 28, 2021
@elpaso
Copy link
Contributor Author

elpaso commented Jan 28, 2021

@rouault what do you think? Did I get this right?

@github-actions github-actions bot added this to the 3.18.0 milestone Jan 28, 2021
Follows GeoServer convention, fixes qgis#36584
@rouault
Copy link
Contributor

rouault commented Jan 29, 2021

@rouault what do you think? Did I get this right?

It's not an exact science, but what you propose looks good to me

@elpaso elpaso merged commit c9e50cf into qgis:master Feb 3, 2021
@elpaso elpaso deleted the bugfix-gh36584-wfs-inverted-axis branch February 3, 2021 13:36
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The backport to release-3_16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-41242-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 c9e50cfd2dc025f681f81f1fb64b15784bb6b6cf
# Push it to GitHub
git push --set-upstream origin backport-41242-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16

Then, create a pull request where the base branch is release-3_16 and the compare/head branch is backport-41242-to-release-3_16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QGIS Server WFS 1.1: issue with axis order
2 participants