Fix DXF export crash #41918
Merged
Fix DXF export crash #41918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folloup qgis#41900 Also hides aspatial layers from export candidates. I'm not sure if this is correct but thre was an assert that was hit when aspatial layers were present, now I don't know if the assert (which is about the size of the layers list and the layer list from custom layer order, that only contains spatial layers) has been there forever and no one actually tested in dev mode with aspatial layers. In any event, getting aspatial layers back into the list is easy but then we'd need to alter the logic that builds the ordered layers list and remove the assert.
elpaso
added
the
Bug
|
@jef-n are aspatial/geometryless layers supposed to be exported to DXF? |
no |
nyalldawson
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #41900
Also hides aspatial layers from export candidates. I'm not sure
if this is correct but there was an assert that was hit
when aspatial layers were present, now I don't know if the
assert (which is about the size of the layers list and
the layer list from custom layer order, that only contains
spatial layers) has been there forever and no one actually
tested in dev mode with aspatial layers.
In any event, getting aspatial layers back into the list
is easy but then we'd need to alter the logic that builds
the ordered layers list and remove the assert.