[MetaSearch] mask password when opening connection properties dialog (#42760)

[tomkralidis]

Description

Fixes #42760

[Gustry]

What about https://qgis.org/api/classQgsPasswordLineEdit.html ?

[tomkralidis]

What about https://qgis.org/api/classQgsPasswordLineEdit.html ?

I couldn't get this working (NoSuchWidgetError). Is there a difference in using QgsPasswordLineEdit vs. QLineEdit ?

[agiudiceandrea]

I couldn't get this working (NoSuchWidgetError). Is there a difference in using QgsPasswordLineEdit vs. QLineEdit ?

Hi @tomkralidis, in order to correctly use QgsPasswordLineEdit it seems you need to have the following lines in newconnectiondialog.ui (note the <header>qgis.gui</header> property):

 <customwidgets>
  <customwidget>
   <class>QgsPasswordLineEdit</class>
   <extends>QLineEdit</extends>
   <header>qgis.gui</header>
  </customwidget>
 </customwidgets>

QgsPasswordLineEdit is different from QLineEdit as the former allow the user to toggle the password visibility

[tomkralidis]

Thanks @agiudiceandrea . PR updated to use QgsPasswordLineEdit

[Gustry]

Nitpicking, but the QgsPasswordLineEdit will do it for you when it is needed :)
https://github.com/qgis/QGIS/blob/master/src/gui/qgspasswordlineedit.cpp#L54

[Gustry]

Thanks @agiudiceandrea, indeed you might need to use the "Promote widget" for instance in QtDesigner https://doc.qt.io/qt-5/designer-using-custom-widgets.html it will add these lines.

[agiudiceandrea]

you might need to use the "Promote widget" for instance in QtDesigner ... it will add these lines.

@Gustry the issue with QT Designer and QGIS custom widgets (at least on Windows / OSGeo4W) is that if you use e.g. a QgsPasswordLineEdit widget, the QT Designer adds the following lines to the .ui file

 <customwidgets>
  <customwidget>
   <class>QgsPasswordLineEdit</class>
   <extends>QLineEdit</extends>
   <header>qgspasswordlineedit.h</header>
  </customwidget>
 </customwidgets>

The <header>qgspasswordlineedit.h</header> property leads (sometimes) to the NoSuchWidgetError error if the form is used in Python, while it's ok in C++.

Substituting <header>qgspasswordlineedit.h</header> with <header>qgis.gui</header> fixes the issue in Python.

See #38472 (comment)

[Gustry]

Suggested change

	<widget class="QgsPasswordLineEdit" name="lePassword">
	<property name="echoMode">
	<enum>QLineEdit::Password</enum>
	</property>
	</widget>
	<widget class="QgsPasswordLineEdit" name="lePassword"/>

According to the discussion on gitter @tomkralidis ?
Otherwise, I was thinking the "eye" graphic icon might not be synchronized with the status of showing or not the password :)

[tomkralidis]

Thanks @Gustry makes sense. Changes pushed.

[Gustry]

LGTM