Fix incorrect project CRS when loading project (fix #16149) #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a situation where loading a project results in incorrect project & canvas CRS. The bug is trigerred whenever something in the project load calls a processEvents() call, eg restoring a project with layer count enabled on a layer or with a composer html item. When this occurs, the "auto-set CRS to first added layer" code would kick in early and replace the project's CRS with that of the first layer loaded. To avoid this disable the "auto-set CRS" code when loading layers from a project.
|
That's fantastic! Let me try the PR with a project of mine that would trigger this issue. |
|
@nyalldawson , all good here, issue is gone. |
|
@nyalldawson , this has been tried on two machines here for a couple of days, no collateral regression found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a situation where loading a project results in incorrect project & canvas CRS. The bug is trigerred whenever something in the project load calls a processEvents() call, eg restoring a project with layer count enabled on a layer or with a composer html item.
When this occurs, the "auto-set CRS to first added layer" code would kick in early and replace the project's CRS with that of the first layer loaded.
To avoid this disable the "auto-set CRS" code when loading layers from a project.