New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Metadata schema for WP1 for QEP-91 #4330
Conversation
resources/qgis-resource-metadata.xml
Outdated
<keyword>kw2</keyword> | ||
</keywords> | ||
<fees>None</fees> | ||
<accessconstraints>None<accessconstraints> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessconstraints isn't included in the .xsd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
Thinking out loud... could we add a travis check to run xmllint to validate the sample xml against the xsd? |
Can we also get documentation tags added to the xsd please? |
resources/qgis-resource-metadata.xsd
Outdated
<xs:element name="keywords" type="rm:keywordsType" minOccurs="0" maxOccurs="unbounded"/> | ||
<xs:element name="fees" type="xs:string" minOccurs="0"/> | ||
<xs:element name="constraints" type="xs:string" minOccurs="0" maxOccurs="unbounded"/> | ||
<xs:element name="rights" type="xs:string" minOccurs="0" maxOccurs="unbounded"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get an example rights and constraints added to the sample .xml file please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any rights in there yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
resources/qgis-resource-metadata.xsd
Outdated
<xs:element name="name" type="xs:string"/> | ||
<xs:element name="organization" type="xs:string" minOccurs="0"/> | ||
<xs:element name="position" type="xs:string" minOccurs="0"/> | ||
<xs:element name="address" type="rm:addressType" minOccurs="0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow multiple addresses for each contact? Eg postal address + street address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. Made address 1..n cardinality.
resources/qgis-resource-metadata.xsd
Outdated
</xs:element> | ||
<xs:element name="parentidentifier" type="xs:string" minOccurs="0"> | ||
<xs:annotation> | ||
<xs:documentation>A Refernece, URI, URL or some other mechanism that that a given resource is a part of (child).</xs:documentation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refernece -> reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed thanks.
@nyalldawson good idea! First pass docs/annotations added to XML Schema inline as discussed, for review/comment. |
resources/qgis-resource-metadata.xsd
Outdated
<xs:attribute name="dimensions" type="xs:integer" default="2"/> | ||
<xs:attribute name="crs" type="xs:string" use="required"> | ||
<xs:annotation> | ||
<xs:documentation>Coordinate refernece system.</xs:documentation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refernece -> reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
resources/qgis-resource-metadata.xsd
Outdated
* description: abstract text about link | ||
* url: endpoint. If the URL is an OWS server, specify the *base* URL only without parameters like service=xxx..... | ||
* format: format specification of online resource. Strongly suggested to use GDAL/OGR format values | ||
* mimeType: MIME type represenative of the online resource response (image/png, application/json, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
representative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
What do you think about adding an element:
This would allow users and processes to embed information about the history of a particular resource. I'd love to have something like this which could be used by processing to automatically append a history element to the existing metadata of a layer when an algorithm is performed. E.g. reprojecting a layer would add a "Reprojected to EPSG:4326 on 2017-04-11". Then it'd be trivial to see exactly how a particular layer was derived - e.g.
(Potentially layer edit operations could also append to this history, e.g. "54 features added"/"3 features edited using node tool") |
Good idea @nyalldawson; added. |
Should I rebase to master head? |
In the interest of moving this forward, I propose:
|
@timlinux @kalxas @tomkralidis what's the status here? Should we lock this in now? |
wow! this is really super cool. Thanks! |
Feedback has slowed here - I think we're safe to merge |
Thanks @nyalldawson |
Description
This PR introduces a QGIS metadata schema as part of WP1 of QEP-91.
Checklist
fixes #11111
in the commit message next to the description[FEATURE]
in the commit message[needs-docs]
in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.sh
script before each commit