-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix qgsinterpolator with NULL value #43302
Conversation
@vcloarec maybe it makes sense to add a test to prevent breakage in future? |
Does it fix #42689 too ? |
surely |
@alexbruy , yes, with tests, it would be better... on my side, no time to write tests for now... |
Let's leave this open for now -- I'll add a test then we can merge |
or @nyalldawson , let me write a test later, I think I could find few time for it before 3.20 release... |
b8ab5ff
to
e65d367
Compare
tests added |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-43302-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 23ffd06cfdad8747f3f7485820bb4ffdfb12fe23,6f736d9bd56023aef43c975dbe15bd3aaa1fee37,e65d3676faff49cb82979f177e7c6c4715997dec
# Push it to GitHub
git push --set-upstream origin backport-43302-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16 Then, create a pull request where the |
fix #43286 and #42689