Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning in QgsMeshDatasetGroupStore::readXml() #43304

Merged

Conversation

rouault
Copy link
Contributor

@rouault rouault commented May 20, 2021

/home/even/qgis/qgis/src/core/mesh/qgsmeshdatasetgroupstore.cpp: In member function ‘void QgsMeshDatasetGroupStore::readXml(const QDomElement&, const QgsReadWriteContext&)’:
/home/even/qgis/qgis/src/core/mesh/qgsmeshdatasetgroupstore.cpp:329:29: warning: ‘sourceIndex’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  329 |     mRegistery[globalIndex] = DatasetGroup{source, sourceIndex};

Introduced in 7a1c29d, so master only

```
/home/even/qgis/qgis/src/core/mesh/qgsmeshdatasetgroupstore.cpp: In member function ‘void QgsMeshDatasetGroupStore::readXml(const QDomElement&, const QgsReadWriteContext&)’:
/home/even/qgis/qgis/src/core/mesh/qgsmeshdatasetgroupstore.cpp:329:29: warning: ‘sourceIndex’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  329 |     mRegistery[globalIndex] = DatasetGroup{source, sourceIndex};

```

Introduced in 7a1c29d, so master only
@github-actions github-actions bot added this to the 3.20.0 milestone May 20, 2021
@nyalldawson nyalldawson merged commit e04499a into qgis:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants