[OGR provider] Do not corrupt values when updating a GPKG feature #43311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
added
Bug
and that the fid value is included in the fields to update, and that it doesn't change. Also rollback all changes if an update of FID is attempted. Fixes qgis#42274
|
Even, thank you so much for looking at this! |
Does this mean users can no longer manually modify fids? Or is this only in the case that an error occurs? |
It was already impossible to modify the FID in the Geopackage case, but no error was returned to the caller. |
nyalldawson
approved these changes
May 24, 2021
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_16 release-3_16
# Navigate to the new working tree
cd .worktrees/backport-release-3_16
# Create a new branch
git switch --create backport-43311-to-release-3_16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 09caca9312ae4e32314d2c28ad1c28295e1999d1
# Push it to GitHub
git push --set-upstream origin backport-43311-to-release-3_16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_16Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and that the fid value is included in the fields to update, and that it
doesn't change.
Also rollback all changes if an update of FID is attempted.
Fixes #42274